-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.0] Remove default content-length header from MultipartStream class #581
base: 2.6
Are you sure you want to change the base?
[3.0] Remove default content-length header from MultipartStream class #581
Conversation
Thanks for sending this in. I wanna wait till 3.0.0 to make this change. There are some other arguably breaking changes to make at the same time as this. |
3.0.0 should be coming out this year, if I can find the time to work on it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 2 weeks if no further activity occurs. Thank you for your contributions. |
I think this pull request is very important. Some legacies system can't manage the "Content-Length" header into "multipart/form-data" boundary and cut off the request. For reference see the RFC 7578 in section 4.8 wich specify: 4.8. Other "Content-" Header Fields The multipart/form-data media type does not support any MIME header Older system are not compliant because not apply the MUST be ignore policy but on the other side this code non apply the MUST NOT be included policy. |
I don't disagree. A 3.0 release is still planned. |
Thanks, do you have an expected release date? |
No, not yet. I hope some time in the summer. |
I am likely to create a 3.0 branch in the next few days/weeks, and merge this, so you may be able to use an experimental 3.0-dev version for a bit if you want. |
Yes, of course; after merge i can use the experimental 3.0-dev. Actually i've already overrided in my project Client.php and MultipartStream.php files for exclude the "Content-Length" and works well. |
Hi @GrahamCampbell, any news on this? |
This is for sure still planned for 3.0.0. |
Content-Length
in multipart bodies is not necessary. As far as I can verify is not used in any browser or other HTTP client.For reference